Support Zulu bundle flags #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Zulu distributions come with extra flags. I care about EA builds, but there are other flags, which currently fail the string.split test. This PR attempts to handle these flags on the Zulu part of the version string. The Java version string can also contain -ea, but I assume the 'rest' of the string is the Java version string.
Generate changelog in
|
CRogers
reviewed
Jul 29, 2022
| import org.immutables.value.Value; | ||
|
|
||
| final class AzulZuluJdkDistribution implements JdkDistribution { | ||
| // See https://docs.azul.com/core/zulu-openjdk/versioning-and-naming for flag details. | ||
| private static final ImmutableSet<String> BUNDLE_FLAGS = | ||
| ImmutableSet.of("ea", "embvm", "cp1", "cp2", "cp3", "c2", "criu", "cr", "crac"); |
There was a problem hiding this comment.
There's a criu version of the JDK?? Interesting....
There was a problem hiding this comment.
worth saying: some of these flags are discontinued! (embvm is one). One only works for 32-bit ARM. The docs are very clear that just because a flag exists doesn't necessarily mean you can acquire a JVM with it set!
CRogers
approved these changes
Jul 29, 2022
|
Released 0.23.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Zulu distributions come with extra flags. I care about EA builds,
but there are other flags, which currently fail the string.split test.
This PR attempts to handle these flags on the Zulu part of the version
string. The Java version string can also contain -ea, but I assume the
'rest' of the string is the Java version string.
Before this PR
JDK version
19.0.21-ea-19.0.0-ea.6fails.After this PR
JDK version
19.0.21-ea-19.0.0-ea.6passes.Possible downsides?
This PR assumes that the rest of the string is the java version. So e.g. '19.0.21-ea-THIS!IS-NOT!A!VERSION!' would pass. This is similar behaviour to as present since the non-sensical openjdk version could just as easily be '19.0.21-ea-THIS!IS!NOT!A!VERSION' which would have passed prior to this PR.